feat: Increase indent of figures #8323
Open
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This carries some risk, but on balance, I think that it is a good change. We see a lot of documents that include sourcecode or ASCII art that appears at the same indent level as the rest of the text. This makes it hard to visually distinguish figures. This increases the indent for these, where possible. It retains the indentation flexbox hack that ensures that wider figures reduce the margin. The risk is that this will double the indent where people have manually added one. The text formatter of xml2rfc doesn't add an indent, so this is also an inconsistency in appearance. My hope is that xml2rfc will be updated to match, with people learning not to add their own indentation to documents.
martinthomson
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8323 +/- ##
=======================================
Coverage 88.72% 88.72%
=======================================
Files 310 310
Lines 40882 40882
=======================================
Hits 36273 36273
Misses 4609 4609 ☔ View full report in Codecov by Sentry. |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This carries some risk, but on balance, I think that it is a good change.
We see a lot of documents that include sourcecode or ASCII art that appears at the same indent level as the rest of the text. This makes it hard to visually distinguish figures.
This increases the indent for these, where possible. It retains the indentation flexbox hack that ensures that wider figures reduce the margin.
The risk is that this will double the indent where people have manually added one. The text formatter of xml2rfc doesn't add an indent, so this is also an inconsistency in appearance. My hope is that xml2rfc will be updated to match, with people learning not to add their own indentation to documents.